This repository was archived by the owner on Sep 30, 2024. It is now read-only.
show "Copied" indicator when copying an access token#63936
Merged
Conversation
For some reason, the indication that the text was copied was removed for secrets. The indication does not show the secret value itself, so I don't see why that change was made. It is helpful to the user to give them feedback that the secret was in fact copied.
eseliger
approved these changes
Jul 19, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
oh thanks, yes that seems odd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the indication that the text was copied was removed for secrets. The indication does not show the secret value itself, so I don't see why that change was made. It is helpful to the user to give them feedback that the secret was in fact copied.
Test plan
Click the copy button after creating an access token