Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

allow non-site admins to list their orgs' members on dotcom#63934

Merged
sqs merged 1 commit into
mainfrom
sqs/dotcom-perms
Jul 19, 2024
Merged

allow non-site admins to list their orgs' members on dotcom#63934
sqs merged 1 commit into
mainfrom
sqs/dotcom-perms

Conversation

@sqs

@sqs sqs commented Jul 19, 2024

Copy link
Copy Markdown
Member

Previously, only site admins could see the members of an org, even of orgs that they were a member of. This restriction does not make any sense and makes the orgs feature broken on dotcom.

Test plan

Added test.

@cla-bot cla-bot Bot added the cla-signed label Jul 19, 2024
@sqs sqs requested review from a team July 19, 2024 07:13
Comment thread cmd/frontend/graphqlbackend/users.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird this was reused here, that resolver doesn't even have anything to do with orgs 😬

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

Previously, only site admins could see the members of an org, even of orgs that they were a member of. This restriction does not make any sense and makes the orgs feature broken on dotcom.
@sqs sqs force-pushed the sqs/dotcom-perms branch from 6289eb0 to 00b68ec Compare July 19, 2024 07:17
@sqs sqs merged commit 85359ac into main Jul 19, 2024
@sqs sqs deleted the sqs/dotcom-perms branch July 19, 2024 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants