This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Fix and cleanup compare page#63928
Merged
Merged
Conversation
I just noticed that the revision pickers on the compare page don't work.
That's because I made a last minute change to rename the parameter but
forgot to acutally update the parameter when constructing the URL.
This also makes two additional changes:
- Remove `{@debug ...}` expression that was accidentally left in (I feel
like Svelte should remove this in prod builds).
- Adds a `display` prop to button group, and the rev picker, which works
the same as in `Button`. Setting `width: 100%` as done previously
causes wrapping on the compare page. I don't think inline elements
should be set to 100% width. But without it the button doesn't stretch
in the sidebar.
This new prop allows the caller to influence this behavior.
camdencheek
approved these changes
Jul 18, 2024
61fdb4c to
69a4d80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that the revision pickers on the compare page don't work. That's because I made a last minute change to rename the parameter but forgot to acutally update the parameter when constructing the URL.
This also makes two additional changes:
{@debug ...}expression that was accidentally left in (I feel like Svelte should remove this in prod builds).displayprop to button group, and the rev picker, which works the same as inButton. Settingwidth: 100%as done previously causes wrapping on the compare page. I don't think inline elements should be set to 100% width. But without it the button doesn't stretch in the sidebar. This new prop allows the caller to influence this behavior.Test plan
Tested the compare page and verified that the revision picker stretches in the sidebar.