This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/frontend/httpapi: improve request reader#63923
Merged
Merged
Conversation
d684c4d to
7589c97
Compare
evict
reviewed
Jul 19, 2024
a3b5801 to
3d1b082
Compare
It's very unlikely someone is going to exceed this from our GraphQL API. 20MiB is a lot for a single decompressed request. bazel
evict
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets a maximum decompressed size limit for requests of 20MiB. For more details, please refer to: https://github.com/sourcegraph/security-issues/issues/398.
Test plan
Tested locally, the limit reader works as intended.