This repository was archived by the owner on Sep 30, 2024. It is now read-only.
GraphQL: improve query cost violation message#63921
Merged
Merged
Conversation
evict
commented
Jul 18, 2024
c71d792 to
01fe7f9
Compare
eseliger
reviewed
Jul 19, 2024
eseliger
reviewed
Jul 19, 2024
01fe7f9 to
6489cf2
Compare
eseliger
approved these changes
Jul 22, 2024
792e871 to
bcf5460
Compare
It's a bit unclear for users what the error message is for. This PR improves the error message by extending the GraphQL error message with additional context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit unclear for users what the error message is for. This PR improves the error message by extending the GraphQL error message with additional context.
Linear issue: https://linear.app/sourcegraph/issue/SEC-1792/add-error-message-specifying-which-cost-setting-was-exceeded-in.
Test plan
CI tests
Changelog