This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(svelte): Improve commit page layout on mobile#63920
Merged
Conversation
vovakulikov
approved these changes
Jul 18, 2024
I noticed that the commit page doesn't render well on mobile when the commit has a commit message. This commit refactors how the `Commit` component is rendered, including on mobile, which affects both the commits page as well as the commit page. The two most important changes: - The component now uses CSS grid to be more flexible about how individual elements are arranged. - On mobile we don't show expand the message inline anymore but instead show it full screen. I think that works well for the commits list too because now you can open and read a longer commit message without having to scroll the commits list itself.
c280f8a to
029366c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the commit page doesn't render well on mobile when the commit has a commit message.
This commit refactors how the
Commitcomponent is rendered, including on mobile, which affects both the commits and the commit page.The two most important changes:
Here are side by side comparisons. The differences in the non-mobile view are barely perceivable, it's mostly spacing changes.
Test plan
Manually inspecting the commits and commit pages. Opened a long commit message to test that the message is properly scrollable.