This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add separate shadow value for hovercards#63918
Merged
Merged
Conversation
taiyab
reviewed
Jul 18, 2024
taiyab
left a comment
Contributor
There was a problem hiding this comment.
From a visual perspective: LGTM!
camdencheek
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The box-shadow value for code intel hover cards is too dark, and makes the content directly below more difficult to read.
Before:
After:
I added a new scss variable so it can be re-used. I'm not sure I've put it in the best place in the codebase though, let me know if you think there's a better location for it.
Test plan
Manual/visual testing
Changelog