This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg/msp: enable alerting by default for production projects#63912
Merged
Conversation
bobheadxi
reviewed
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opsgenie alert notifications for critical alerts should be enabled by default for production projects or where
env.alerting.opsgenieis set to true.Closes CORE-223
Test plan
Tested locally by running
sg msp genfor aprodenv which doesn't have an alerting config and verifying that notification suppression was disabledSet
env.alerting.opsgenieto false which enabled suppression again.No changes to
testenvironments unlessenv.alerting.opsgenieis set to true.