This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(build-tracker): Failed back-compat doesn't count towards branch-locking quota#63911
Merged
BolajiOlajide merged 6 commits intoJul 25, 2024
Merged
Conversation
BolajiOlajide
commented
Jul 18, 2024
| logger.Info("config loaded from environment", log.Object("config", log.String("SlackChannel", config.SlackChannel), log.Bool("Production", config.Production))) | ||
|
|
||
| bqWriter, err := contract.BigQuery.GetTableWriter(context.Background(), "agent_status") | ||
| bqWriter, err := contract.BigQuery.GetTableWriter(ctx, "agent_status") |
Contributor
Author
There was a problem hiding this comment.
This might be intentional, but I noticed we were creating a new context here instead of using the one from the service for getting the table writer for big query.
Contributor
There was a problem hiding this comment.
@jac @bobheadxi whats the lifetime on the ctx passed to Initialize? Is this change safe?
Member
There was a problem hiding this comment.
Yeah, that should be fine. The context passed to initialize is a context.Background()
| github.com/aws/smithy-go v1.13.5 | ||
| github.com/beevik/etree v1.3.0 | ||
| github.com/buildkite/go-buildkite/v3 v3.0.1 | ||
| github.com/buildkite/go-buildkite/v3 v3.11.0 |
Contributor
Author
There was a problem hiding this comment.
The TriggeredFrom on builds wasn't available in the previous version of this library, which is why I had to update it.
burmudar
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DINF-51
Context
If a back-compat step on main fails, the build is marked as having failed. However, we don't treat that as a failure in build-tracker, resulting in no #buildkite-main post and not counting towards failed build quota for locking main.
The reason why this was happening is that the Backcompat build wasn't linked to the main Sourcegraph build in anyway. However, when a backcompat fails the main build reflects the status of this failure, but we do not use this field when determining the status of a build, so it doesn't work for our use case.
We instead do a walkthrough of all the jobs associated with a build to figure out if the build has failed, fixed or is passing.
With this logic, it means we have to link the steps from child builds that a particular build triggers to it's parent.
Test plan
Changelog