show org name not displayName in most places#63907
Conversation
965353b to
027b049
Compare
BolajiOlajide
left a comment
There was a problem hiding this comment.
I think there's a conversation to be had around this change. There's been discussions during the Batch Changes era about displaying the displayName for both users and org namespace.
Whilst the displayName is non-canonical, it is the one slug that's easily editable and recognizable within Sourcegraph. In the user dropdown, the display name is what we show to users and this change could bring about confusion.
For example on S2, we have an org with the name sourcegraph and displayName of CodeSearch.
I've seen customers create orgs with weird names and they usually depend on the displayName especially during org changes.
Personally, I'd even prefer displaying the displayName for both User and Org in the namespace selector component.
|
@BolajiOlajide What if we change what’s displayed in the user menu as well to just show the name not displayName? Then it’s consistent. What are the situations you’re aware of where that would be bad for customers? |
|
Since displayName is not globally unique using that field could actually be quite misleading. I wonder if we should have a displayName at all - or if we should, if we should instead say whenever you display So overall I am ok with this change. |
The one case that stands out was after a customer had a re-org, they wanted the org to reflect it's new name and all they did was update the |
Good point on it's uniqueness. |
|
@sqs If we can make the update in the sidebar, it will at the very least reduce confusion from customers. We can then communicate this change as time goes on. |
027b049 to
3bb0431
Compare
|
@BolajiOlajide Thanks! Updated all the other similar places where we showed the org displayName to just show the name. |
941383e to
6801aa8
Compare
Previously, organizations would be displayed using their `displayName`, which was inconsistent and non-canonical. For example, when creating a batch change or saved search, the dropdown will now show `sourcegraph` instead of `Sourcegraph` (where the latter is the display name).
6801aa8 to
2b6e681
Compare
The org displayName is not unique and is often longer, so let's just show the org name in most places.
2b6e681 to
6a7ffb9
Compare
Previously, organizations would be displayed using their
displayName, which was inconsistent and non-canonical. ThedisplayNameis also longer, so it's not suited to display in select menus and other similar places.For example, when viewing the user menu or creating a batch change or saved search, the dropdown will now show
sourcegraphinstead ofSourcegraph(where the latter is the display name).Test plan
Go to create a batch change or saved search and confirm that org names not displayNames are shown.
Changelog
abc-corpnotABC Corp(if the latter was theabc-corp's display name).