This repository was archived by the owner on Sep 30, 2024. It is now read-only.
withAuthenticatedUser: use react-router-dom hooks & add test#63906
Merged
Conversation
This improves the typings to remove some inscrutable inferred types and some weird type errors if you didn't use React.PropsWithChildren.
camdencheek
approved these changes
Jul 18, 2024
Member
|
LGTM. Always happy to have more legible types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the typings to remove some inscrutable inferred types and some weird type errors if you didn't use React.PropsWithChildren. Also refactors the code and exposes a new component AuthenticatedUserOnly that's simpler and can be used when you don't need to do prop propagation of authenticatedUser.
Test plan
CI