This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[sg] Make rfc command use private RFCs by default#63902
Merged
Conversation
burmudar
approved these changes
Jul 18, 2024
BolajiOlajide
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
sg rfccommand to introduce a new flag--public(previously, an implicit default) and removes the flag--private(new default).This change implements part of our new approach to RFCs (private by default, context need to follow-up).
Test plan
sg rfc create "test new default"and a private RFC was createdsg rfc --public create "test public"and a public RFC was createdsg rfc listand private RFCs were listedsg rfc --public listand public RFCs were listed