This repository was archived by the owner on Sep 30, 2024. It is now read-only.
cody-gateway: handle missing Google response#63895
Merged
Merged
Conversation
- Logs a warning instead of returning an error when the Google response is missing - This prevents the API from returning an error when the Google response is empty, which can happen in some cases
chrsmith
approved these changes
Jul 19, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
Seems legit. But what do end-users see when they hit this situation? Do they see a message from Google to the effect of "no dawg, I ain't going to answer that"?
Contributor
Author
When I try it in Google AI studio I just get an empty answer 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
only the log level was updated for empty responses. the function behavior was not changed.
Changelog
cody-gateway: log missing Google response as warning