This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/sg: do not persist external secrets#63890
Merged
Merged
Conversation
evict
approved these changes
Jul 18, 2024
evict
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thanks for doing this. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secrets fetched from GSM should probably not be stored locally. As we increase the usage of fetching external secrets, this stuff is increasingly sensitive, particularly for SAMS stuff - every time it's used, we should ensure that the user has the required permissions, and also only store external secrets in-memory.
It looks like several other callsites make use of the persistence of other secrets e.g. those prompted from users, so this change specifically targets the
GetExternalmethod. Additionally, I also added a check on load to delete any legacy external secrets that are stored to disk on load - we can remove this after a few weeks.Test plan
Unit tests asserts old behaviour and new desired behaviour
sg start -cmd cody-gatewayuses external secrets and works as expectedAfter running
sg,sg secret listhas no external secrets anymore