Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg: check for nil multiError#63889

Merged
burmudar merged 3 commits into
mainfrom
wb/sg-check-for-nil-multi-err
Jul 17, 2024
Merged

sg: check for nil multiError#63889
burmudar merged 3 commits into
mainfrom
wb/sg-check-for-nil-multi-err

Conversation

@burmudar

Copy link
Copy Markdown
Contributor

Fixes https://github.com/sourcegraph/devx-support/issues/1097

Test plan

Before

👉 [      step] Pretending to run step "github:pr"
   [ github:pr] set -eu
   [ github:pr] gh pr create \
   [ github:pr]   --fill \
   [ github:pr]   --draft \
   [ github:pr]   --title "(internal) release_patch: build v5.5.1220" \
   [ github:pr]   --body "Test plan: automated release PR, CI will perform additional checks"
   [ github:pr] echo "🚢 Please check the associated CI build to ensure the process completed".
   [ github:pr]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x1059c1380]

goroutine 42 [running]:
github.com/sourcegraph/sourcegraph/dev/sg/internal/analytics.processEvents({0x10b4a71d8, 0x1400188eaf0}, 0x1400330a140, {{0x10b482ed8?, 0x140033141f8?}}, 0x140033080c0)
        github.com/sourcegraph/sourcegraph/dev/sg/internal/analytics/background.go:107 +0x320
main.init.func52.BackgroundEventPublisher.4({0x10b4a71d8, 0x1400188eaf0}, 0x1400330a140)
        github.com/sourcegraph/sourcegraph/dev/sg/internal/analytics/background.go:30 +0x14c
github.com/sourcegraph/sourcegraph/dev/sg/internal/background.Run.func1()
        github.com/sourcegraph/sourcegraph/dev/sg/internal/background/background.go:62 +0x74
created by github.com/sourcegraph/sourcegraph/dev/sg/internal/background.Run in goroutine 1
        github.com/sourcegraph/sourcegraph/dev/sg/internal/background/background.go:57 +0x174

After

👉 [      step] Pretending to run step "github:pr"
   [ github:pr] set -eu
   [ github:pr] gh pr create \
   [ github:pr]   --fill \
   [ github:pr]   --draft \
   [ github:pr]   --title "(internal) release_patch: build v5.5.1220" \
   [ github:pr]   --body "Test plan: automated release PR, CI will perform additional checks"
   [ github:pr] echo "🚢 Please check the associated CI build to ensure the process completed".
   [ github:pr]

deploy-sourcegraph-k8s on  main [?⇕] via 🐹 v1.22.3 took 5s

Changelog

@burmudar burmudar requested a review from a team July 17, 2024 19:34
@burmudar burmudar self-assigned this Jul 17, 2024
@cla-bot cla-bot Bot added the cla-signed label Jul 17, 2024
@burmudar burmudar requested a review from a team July 17, 2024 19:34
@burmudar burmudar enabled auto-merge (squash) July 17, 2024 19:35
@burmudar burmudar merged commit 26c2b33 into main Jul 17, 2024
@burmudar burmudar deleted the wb/sg-check-for-nil-multi-err branch July 17, 2024 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants