This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Special oauth containers#63880
Merged
Merged
Conversation
0a9ed6c to
d4b2a66
Compare
arafatkatze
commented
Jul 17, 2024
DaedalusG
approved these changes
Jul 18, 2024
DaedalusG
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but I'd get a member of a cody team to approve before merging
willdollman
reviewed
Jul 18, 2024
willdollman
reviewed
Jul 18, 2024
evict
reviewed
Jul 18, 2024
willdollman
reviewed
Jul 18, 2024
emidoots
reviewed
Jul 18, 2024
emidoots
left a comment
Member
There was a problem hiding this comment.
Looks like you got some good feedback from others on code quality already, but generally lgtm from a direction/how you're approaching this POV.
If you want a follow-up review when you're ready to land this, lmk.
56eff3a to
984beeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See a description in Linear
Test plan
Tested with local builds and see linear for more.
Changelog