This repository was archived by the owner on Sep 30, 2024. It is now read-only.
factor out PatternConstrainedInput#63869
Merged
Merged
Conversation
bahrmichael
reviewed
Jul 17, 2024
fkling
reviewed
Jul 17, 2024
Comment on lines
21
to
22
Contributor
There was a problem hiding this comment.
According to the page you linked to, the pattern is compiled with the v flag. Should we be using that instead?
This is an input element that constraints the input to look like a path component, used for the names of batch changes (and for prompts in the prompt library in the future).
f3984de to
4adfdef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an input element that constraints the input to look like a path component, used for the names of batch changes (and for prompts in the prompt library in the future).
Also fixes an invalid regexp (it needs to escape
-because the'v'flag is used; see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/pattern).Test plan
Test against existing batch change create form name input. Try invalid inputs.