This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/sg: support correct completions on 'sg start -cmd'#63861
Merged
Conversation
burmudar
approved these changes
Jul 16, 2024
jamesmcnamara
approved these changes
Jul 16, 2024
jamesmcnamara
left a comment
Contributor
There was a problem hiding this comment.
Tested it out locally! works great :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sg runis supposed to be deprecated in favour ofsg start -cmd, but thesg startcompletions don't work with-cmdlikesg rundoes.This change updates
sg startcompletion to check for the-cmdflag, and if it is provided, offer completions for commands instead of command_sets_ (the defaultsg startbehaviour).Test plan
Changelog
sg start -cmdnow offer valid suggestions.