This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody: add access token callback pages for CLI, Eclipse and VS#63849
Merged
olafurpg merged 1 commit intoJul 16, 2024
Merged
Conversation
Previously, only the JetBrains and Neovim Cody plugins had dedicated pages to authorize access token redirects to a localhost port. Other clients like the Cody CLI and Eclipse plugin reused the JetBrains page, which technically works but is problematic because the UI says the user is authorizing "JetBrains" when in reality they're authorizing other clients. This PR fixes the problem by adding dedicated pages for the Cody CLI, Eclipse plugin and Visual Studio extension.
umpox
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CODY-2661
Previously, only the JetBrains and Neovim Cody plugins had dedicated pages to authorize access token redirects to a localhost port. Other clients like the Cody CLI and Eclipse plugin reused the JetBrains page, which technically works but is problematic because the UI says the user is authorizing "JetBrains" when in reality they're authorizing other clients. This PR fixes the problem by adding dedicated pages for the Cody CLI, Eclipse plugin and Visual Studio extension.
Test plan
Didn't test this locally because it takes me a long time to setup Docker access. The diff is small and should be low-risk to merge. I manually searched for 'JETBRAINS' in this directory and confirmed there are no remaining special cases for JetBrains.
Changelog