This repository was archived by the owner on Sep 30, 2024. It is now read-only.
misc saved searches followups#63841
Merged
Merged
Conversation
Member
Author
|
auto-merge is on. feel free to turn it off. |
- Don't show the Tools menu on dotcom for now, since there is only 1 item. Users can still access saved searches in their user menu. - Fix an issue where non-site admins on dotcom would see an error at `/saved-searches` until they changed the Owner filter. - Other minor code cleanups.
369c787 to
f3f2a49
Compare
camdencheek
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/saved-searchesuntil they changed the Owner filter.Test plan
Try being a non-site admin and ensure that
/saved-searchesworks.