This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search_jobs): remove trailing * from URL#63821
Merged
stefanhengl merged 2 commits intoJul 16, 2024
Merged
Conversation
Navigating to the Search Jobs overview page now goes to `/search-jobs` instead of `/search-jobs/*` Test plan: manual testing
mmanela
reviewed
Jul 15, 2024
| @@ -25,7 +25,7 @@ export enum PageRoutes { | |||
| BatchChanges = '/batch-changes/*', | |||
| CodeMonitoring = '/code-monitoring/*', | |||
| Insights = '/insights/*', | |||
Contributor
There was a problem hiding this comment.
What is the trailing asterisk intended for?
Member
Author
There was a problem hiding this comment.
CodeMonitoring and Insights have subpages and I believe the asterisk is catch-all for all pages related to insights. Search Jobs only has a single page.
mmanela
approved these changes
Jul 15, 2024
…-page-via-nav-bar-goes-to-a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating to the Search Jobs overview page now goes to
/search-jobsinstead of/search-jobs/*Test plan:
manual testing