This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(sg): do not try to publish analytics when it is disabled#63800
Merged
Conversation
- move creation of usershell context and background context to happen before registration of analtyics, since the background publisher needs the background context to be intialized.
burmudar
commented
Jul 12, 2024
jhchabran
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background publisher was started regardless if analytics was disabled or not. This PR makes it so that we only publish analytics if it is enabled.
To make it work and not duplicate the disabled analytics check, I moved the usershell + background context creation to happen earlier.
Test plan
CI and tested locally
Changelog