This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): Commit/diff style and behavior tweaks#63785
Merged
Conversation
A couple of tweaks to the commit / diff view: - Linking both file paths in the header for renamed files - Collapse renamed file diffs without changes by default - Move "no changes" out of `FileDiffHunks` to not render a border around the test. - Add description for binary files - Adjust line height and font size to match what we use in the file view - Added the `visibly-hidden` utility class to render content for a11y purposes (I didn't test the changes I made with a screenreader though)
fkling
commented
Jul 11, 2024
| line-height: 1.6666666667; | ||
| white-space: nowrap; | ||
| text-align: right; | ||
| -webkit-user-select: none; |
Contributor
Author
There was a problem hiding this comment.
If you look below, this declaration was removed. It's added automatically by the build process.
camdencheek
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of tweaks to the commit / diff view:
FileDiffHunksto not render a border around the test.visibly-hiddenutility class to render content for a11y purposes (I didn't test the changes I made with a screenreader though)Contributes to SRCH-523
Test plan
Manual testing