This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(sg): return different error types depending on secret failure#63779
Merged
Conversation
If we failed getting a secret via a tool - we return CommandErr which contains SecretErr If we failed getting a secret via Google - we return GoogleSecretErr which contains SecretErr Depending on the error we get while trying to persist Analytics we suggest different fixes the user can try.
jhchabran
suggested changes
Jul 11, 2024
jhchabran
left a comment
Contributor
There was a problem hiding this comment.
Nice! Good call!
Requested changes, because left-over + need some godoc 🙏
jhchabran
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we failed getting a secret via a tool - we return CommandErr which contains SecretErr
If we failed getting a secret via Google - we return GoogleSecretErr which contains SecretErr
Depending on the error we get while trying to persist Analytics we suggest different fixes the user can try.
Below is how it looks when we get a GoogleSecretErr
Test plan
Tested locally
Changelog