Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix(svelte): Show correct line numbers in unified diff#63778

Merged
fkling merged 1 commit into
mainfrom
fkling-srch-717-incorrect-line-numbers-in-diff-view
Jul 11, 2024
Merged

fix(svelte): Show correct line numbers in unified diff#63778
fkling merged 1 commit into
mainfrom
fkling-srch-717-incorrect-line-numbers-in-diff-view

Conversation

@fkling

@fkling fkling commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Fixes srch-717

This commit fixes the line numbers for unified diff views, which are used on the commit page and for inline diffs.

Test plan

Manual testing.

Before After
2024-07-11_10-40 2024-07-11_10-38

Fixes srch-717

This commit fixes the line numbers for unified diff views, which are
used on the commit page and for inline diffs.
@fkling fkling requested a review from a team July 11, 2024 08:41
@fkling fkling self-assigned this Jul 11, 2024
@cla-bot cla-bot Bot added the cla-signed label Jul 11, 2024

@camdencheek camdencheek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick!

@fkling fkling merged commit 46794b5 into main Jul 11, 2024
@fkling fkling deleted the fkling-srch-717-incorrect-line-numbers-in-diff-view branch July 11, 2024 11:19
@fkling

fkling commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

Your review too :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants