This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Minor refactoring, fixes#63766
Merged
Merged
Conversation
emidoots
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of minor changes to minimize the diff for "large completions API refactoring".
Most changes are just a refactoring of the
openaicompletions provider, which I apparently missed in https://github.com/sourcegraph/sourcegraph/pull/63731. (There are still some smaller tweaks that can be made to thefireworksorgooglecompletion providers, but they aren't as meaningful.This PR also removes a couple of unused fields and methods. e.g.
types.CompletionRequestParameters::Prompt. There was a comment to the effect of it being long since deprecated, and it is no longer read anywhere on the server side. So I'm assuming that a green CI/CD build means it is safe to remove.Test plan
CI/CD
Changelog
NA