Search: make 'exclude tests' more general#63762
Conversation
There was a problem hiding this comment.
Any suggestions about the name here? We can't just say "exclude tests" because the regexp isn't comprehensive. For example, it will miss Java tests like AgentTest.java. If this was called "exclude tests", Java users would wonder "why didn't it exclude my tests"?
Aside: I looked into crafting a general regexp that covers most test names across languages. This proved tricky, especially because we need to rely on case sensitivity (CamelCaseTest), which we can't really "toggle on" here.
There was a problem hiding this comment.
Personally, I would prefer _test.* over _test.xx.
Alternative: we could use a match group to extract the extension and create a label for it. I played around a bit locally and it would look like this
There was a problem hiding this comment.
The match group approach looks a bit noisy to me. If I were a user, and my results had too many tests, I'd want to exclude as many tests as possible in one click. And it makes the filters panel more "busy" 🤔
As for _test.* -- I wasn't sure about using globbing, since our query language uses regexp. But it does feel natural!
There was a problem hiding this comment.
This was unused
There was a problem hiding this comment.
Just renamed this, as it is not specific to Go (vendor directories are used in other ecosystems too)
5ea44c2 to
f8231b4
Compare
The "Exclude" options in the filter panels are very useful, but many are specific to Go. This change generalizes them so they apply in many more cases:
_testplus extension (covers Go, Python, some Ruby, C++, C, more).testplus extension (covers Javascript, some Ruby)Relates to SPLF-70
Test plan
Added new unit test. Tested manually.