This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: some unrelated cleanups#63757
Merged
Merged
Conversation
d03c437 to
c3a9932
Compare
camdencheek
commented
Jul 10, 2024
Comment on lines
84
to
82
Member
Author
There was a problem hiding this comment.
Instead of trying to make the width correct so the heights match, just set the height to the icon height.
I tried to handle this semantically by exporting the icon size from Icon.module.scss, but was having trouble getting Vite to generate the types correctly (even though it actually did work). I think this is clear enough for now.
c3a9932 to
ede06dc
Compare
fkling
approved these changes
Jul 10, 2024
198e232 to
a27394b
Compare
Member
Author
|
@fkling any ideas why the "copy path with y" test would be failing on this PR? Seems totally unrelated, but it also seems to be failing consistently. |
Contributor
|
@camdencheek "copy path with y" test? I see that something times out but I don't see what... does it happen locally too? |
eee4f1a to
6399caa
Compare
6399caa to
fbb83c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of things I noticed while working on unrelated tasks.
Separatorcomponent, which has been replaced by the Panel APIIconcomponent like all our other icons.Test plan
Visually checked the logo in the top right, and that it lines up when the sidebar menu is opened.