This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(security) : upgrade src-cli version to address CVE#63750
Merged
Conversation
willdollman
approved these changes
Jul 10, 2024
BolajiOlajide
approved these changes
Jul 10, 2024
Collaborator
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 5.5.x -p 63750Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.5.x 5.5.x
# Navigate to the new working tree
cd .worktrees/backport-5.5.x
# Create a new branch
git switch --create backport-63750-to-5.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e95499625c41c684f5e149f708d612cbdc107cb
# Push it to GitHub
git push --set-upstream origin backport-63750-to-5.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.5.xIf you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-63750-to-5.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.5.x
Once the pull request has been created, please ensure the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker images executor, executor-kubernetes, bundled-executor has reported high/critical CVE-2024-24790 , CVE-2023-45288 reported on golang stdlib. Upon testing, src version 5.3.0 was using
1.20.xas per sourcegraph/src-cli@e8e79e0This pull request attempts to upgrade src version to 5.4.0
Test plan
docker run --platform linux/amd64 -it --entrypoint /bin/sh executor:candidateChangelog
Upgrade src-cli version to 5.4.0 to address CVE-2024-24790 , CVE-2023-45288