This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(Source): Properly render multi-line changelist messages from Perforce#63728
Merged
mmanela merged 4 commits intoJul 9, 2024
Merged
Conversation
eseliger
reviewed
Jul 9, 2024
| // For depots converted with git-p4, this special handling is NOT required. | ||
| func maybeTransformP4Subject(ctx context.Context, repoResolver *RepositoryResolver, commit *gitdomain.Commit) *string { | ||
| if repoResolver.isPerforceDepot(ctx) && strings.HasPrefix(commit.Message.Body(), "[p4-fusion") { | ||
| if repoResolver.isPerforceDepot(ctx) && strings.Contains(commit.Message.Body(), "[p4-fusion") { |
Member
There was a problem hiding this comment.
this change should ideally also have failed a test 😆
eseliger
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SRC-431
Mutli-line perforce changelist descriptions were not being handle since the code implicitly assumed they could not exist. This change enables support for them.
Screenshots
Changelist view with both single and multiline commits
Changelist view with expanded commit message
Individual changelist item
Test plan
Changelog