This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(svelte): Add reblame support to blame column#63727
Merged
fkling merged 1 commit intoJul 9, 2024
Conversation
This commit adds a link next to the blame commit message that allows reblaming to a prior commit if available. It extends the existing blame extension. This won't have any affect on the React app because it doesn't pass the configuration option needed to add the extra gutter. Some notes: - I originally used the tooltip component instead of `title` but somehow it starts to break when scrolling the document (tooltips don't show up anymore). I don't know if CodeMirror does anything to the DOM elements that causes this to fail. - The reblame URL also selected the corresponding line so that the correct line is scrolled into view.
fkling
commented
Jul 9, 2024
| }, | ||
| '.cm-gutterElement': { | ||
| lineHeight: '1.54', | ||
| minWidth: '40px !important', |
Contributor
Author
There was a problem hiding this comment.
Don't know why we had this in there. Doesn't seem to be necessary.
camdencheek
approved these changes
Jul 9, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Works great -- thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes srch-612
This commit adds a link next to the blame commit message that allows reblaming to a prior commit if available.
It extends the existing blame extension. This won't have any affect on the React app because it doesn't pass the configuration option needed to add the extra gutter.
Some notes:
titlebut somehow it starts to break when scrolling the document (tooltips don't show up anymore). I don't know if CodeMirror does anything to the DOM elements that causes this to fail.Test plan
Manual testing