This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(redis): set max active redis connections to 1000#63718
Merged
Conversation
Contributor
Author
|
Looking into exposing the redis client count via redis-exporter as well |
jac
approved these changes
Jul 9, 2024
eseliger
approved these changes
Jul 9, 2024
Member
could that track it by client hostname too? that'd be great :) |
Contributor
Author
Seems like I'll have to write a redis lua script do get this metric. Will try to get some time this week to see what I can get :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When active client is 0, there is no limit to the amount of active clients which can lead to Redis quickly reaching it's MaxClient (10000 by default)
For more context see this slack thread
Test plan
CI
Changelog