Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix: better alignemnt of github credentials and check success notice#63717

Merged
bahrmichael merged 2 commits into
mainfrom
bahrmichael/2024-07-09-fix-notice-alignment
Jul 9, 2024
Merged

fix: better alignemnt of github credentials and check success notice#63717
bahrmichael merged 2 commits into
mainfrom
bahrmichael/2024-07-09-fix-notice-alignment

Conversation

@bahrmichael

@bahrmichael bahrmichael commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Closes SRCH-701

Ideally we would use a DismissibleAlert one level up the React component chain, but that's turning out too tricky for the time we have left: https://sourcegraph.slack.com/archives/C07A21XEP0T/p1720486350310899

Test plan

Manual testing

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jul 9, 2024
@bahrmichael bahrmichael requested a review from a team July 9, 2024 14:29
@bahrmichael bahrmichael enabled auto-merge (squash) July 9, 2024 14:34
@bahrmichael bahrmichael disabled auto-merge July 9, 2024 14:42
@bahrmichael bahrmichael enabled auto-merge (squash) July 9, 2024 14:56
@bahrmichael bahrmichael merged commit 62b0c89 into main Jul 9, 2024
@bahrmichael bahrmichael deleted the bahrmichael/2024-07-09-fix-notice-alignment branch July 9, 2024 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants