This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: when in CI we do not need to prompt for an identity#63712
Merged
Conversation
burmudar
commented
Jul 9, 2024
burmudar
commented
Jul 9, 2024
burmudar
commented
Jul 9, 2024
jhchabran
reviewed
Jul 9, 2024
Contributor
Author
Yeah I think is a good point tbh. Otherwise it becomes really nasty in the test to enable, disable and restore the CI env var |
b7f3db4 to
5254c88
Compare
burmudar
commented
Jul 9, 2024
jhchabran
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases when we use SG in CI and then we do not want to prompt for identity
Test plan
CI, unit tests and tested locally
Changelog