This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/dotcom: remove per-user Enterprise subscriptions UI#63698
Merged
Conversation
eseliger
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a legacy of previous self-serve-billing attempts, and is no longer used or necessary, with the presence of the dotcom-wide subscriptions management pages. If we want a self-serve UI for Enterprises in the future, it should be part of the Enterprise Portal UI project.
I asked the 3 most active users of this page, as indicated by V2 telemetry, all of whom were internal, about this and they confirmed it's not used: https://sourcegraph.slack.com/archives/C05GJPTSZCZ/p1720474215464999 https://redash.sgdev.org/queries/854
For now, this is one less thing for us to maintain and migrate for https://linear.app/sourcegraph/issue/CORE-100
Test plan
CI,
sg start dotcom-> user profile page no longer shows the subscriptions tab