This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: encode path components in file header#63695
Merged
Merged
Conversation
Contributor
|
Do we have to do that for the file tree too? And basically anywhere else where we link to files? |
Member
Author
|
Yes, probably. The file tree was the specific one that came to mind for me too, but I tested it and it seemed to work fine |
peterguy
approved these changes
Jul 8, 2024
peterguy
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock if you want to merge this one and followup with other PRs for other file links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding a file with a bunch of special characters in its name to sgtest/weird, I noticed that clicking a link to the file is broken.
This URI-encodes the path components so following the link does not yield a 404.
Test plan
Quick manual test that I can click the file name in the header and it goes to the right place.