This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): Cleanup dependencies#63691
Merged
Merged
Conversation
We have introduced a dependency on wildcard again, which should not be an issue in production but will slow down the initial page load during dev builds. I also took the time clean up other transitive depdencies on modules using React (based on file extension). Turns out that some tsx files should actually be ts files because they don't use React.
camdencheek
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have introduced a dependency on wildcard again, which should not be an issue in production but will slow down the initial page load during dev builds.
I also took the time clean up other transitive depdencies on modules using React (based on file extension). Turns out that some tsx files should actually be ts files because they don't use React.
Test plan
The build system should catch any issues with moved exports.