This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Fixes excessive 'the hotkey ... has already been registered' messages#63679
Merged
fkling merged 1 commit intoJul 6, 2024
Conversation
…red' messages This commit makes two important changes: - The popover component will now only register the ESC key handler when it is open (und unregister when it closes). - The error message was turned into a warning and will now only be triggered in dev builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-697
This commit makes two important changes:
registerHotkeyfunction simply wraps the new function so that existing callsites are not affected by this change.Test plan
Existing unit test, manual testing.
Before this change:
After this change: No messages.