Bump code-web-experimental version to 0.2.0#63675
Conversation
fkling
left a comment
There was a problem hiding this comment.
You should also update the dependency in client/web-sveltekit, or we should update its package.json and BUILD.bazel files to use the version installed at the root (which we already do for some other things anyway).
|
@fkling yeah, I will update svelte version shortly |
| // stylelint-disable-next-line declaration-property-unit-allowed-list | ||
| padding: 1px 3px; | ||
| border-radius: 0.25rem; | ||
| font-family: var(--monaco-monospace-font); |
There was a problem hiding this comment.
@vovakulikov After looking at this on dotcom, it seems that this has no effect because --monaco-monospace-font is not defined.
| color: var(--vscode-textPreformat-foreground); | ||
| background-color: var(--vscode-textPreformat-background); |
There was a problem hiding this comment.
I see that this doesn't effect code blocks. Is that intentional?
I'm asking because in the Svelte version it does affect code blocks because the generated CSS has higher specificity than the CSS shipped with the sidebar. I can see the following bundled sidebar CSS:
._content_1ni0f_82 pre > code {
background-color: var(--code-background);
color: var(--code-foreground);
margin-bottom: 0;
}Which seems to have a higher specificity than the rule in this module. And since --code-background isn't defined it seems to fall back to transparent or being unset.
Just want to clarify what the intentions here are so that I can properly replicate it in the Svelte version.
This PR bumps
cody-web-experimentalpackage to 0.2.0 which includesHere as well I included a few minor UI fixes for the chat which close
I will update the package for the Svelte version as a follow-up early next week.
Test plan