This repository was archived by the owner on Sep 30, 2024. It is now read-only.
add database.NotFoundError helper type#63671
Merged
Merged
Conversation
eseliger
approved these changes
Jul 5, 2024
Member
There was a problem hiding this comment.
maybe cody could write a small test that verifies that this error satisfies the errcode.IsNotFound() check?
Member
There was a problem hiding this comment.
should this type be exported? It's impossible to access noun so no one outside database can create this anyways.
Feels like an implementation detail, no one should ever check for this error, and use the IsNotFound check instead
Use it in the 1 place it seemed obvious. I have other changes where it will be used in more places. This helps standardize our codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use it in the 1 place it seemed obvious. I have other changes where it will be used in more places. This helps standardize our codebase.
Test plan
CI