This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Render correct error page#63663
Merged
fkling merged 1 commit intoJul 5, 2024
Merged
Conversation
Details about the probblem can be found in srch-527. This commit implements a workaround via the `handleError` hook. If this function returns an error then SvelteKit is using that instead of its own error object. So we unwrap the error object ourselves (since SvelteKit fails to do that due to bazel build issues) and ensure this way that the correct error is passed to our error template.
Contributor
Author
|
I added @jamesmcnamara as reviewer because he/you might be interested in why it fails with bazel. |
camdencheek
approved these changes
Jul 5, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Thanks for tracking this down!
Contributor
Author
|
FWIW it seems to work as expected in production now (not unexpected since the integration tests passed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details about the probblem can be found in srch-527 (fixes srch-527).
This commit implements a workaround via the
handleErrorhook. If this function returns an error then SvelteKit is using that instead of its own error object. So we unwrap the error object ourselves (since SvelteKit fails to do that due to bazel build issues) and ensure this way that the correct error is passed to our error template.Test plan
Coincidentally we disabled all error related tests in CI, so by enabling these tests again we should see whether this approach works.