This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(appliance): remove grafana fixtures from most golden tests#63659
Merged
Conversation
Disable grafana in all non-grafana input fixtures, which causes grafana to be removed from most golden fixtures. This follows a pattern we've been using for most service tests: disabling all on-by-default services except the one under test, to make compare-helm diffs easier to read. ``` find internal/appliance/reconciler/testdata/sg -name '*.yaml' | \ xargs sed -Ei '/gitServer:/i\ grafana:\n disabled: true\n' ```
b315359 to
5830a20
Compare
jdpleiness
approved these changes
Jul 8, 2024
DaedalusG
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable grafana in all non-grafana input fixtures, which causes grafana
to be removed from most golden fixtures. This follows a pattern we've
been using for most service tests: disabling all on-by-default services
except the one under test, to make compare-helm diffs easier to read.
Fixes https://github.com/sourcegraph/sourcegraph/pull/63535#issuecomment-2207724318
Draft until base branch merged, but can be reviewed independently.Test plan
This is a cleanup chore for tests.
Changelog