This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add ModelRef.APIVersionID()#63643
Merged
Merged
Conversation
emidoots
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ModelRefencodes three pieces of information to represent the unique identity of the model. So far, we've only needed to pull out theProviderIDandModelID. But now that I'm working on reading this data for the completion APIs, it's time to add theAPIVersionIDfunction too.Note that these functions should really return an
(string, error)since it's possible theModelRefthey are operating on is invalid. But as-is things will explode loudly enough it won't be too difficult to detect, and leaving the function return type asstringmakes it much easier to use.I also added a comment about something I'll address when I get to adding support for fetching new models dynamically from Cody Gateway. Right now there is a validation check that probably should exist but doesn't, and we cannot add it just yet.
Test plan
Added unit tests.
Changelog
NA