This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(local): fix race in sg_start_test.go#63642
Merged
Merged
Conversation
Strum355
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DINF-82; This was very much a rabbithole. A few things:
*output.Outputbeing unsafe, butoutputtest.Bufferas it happened again (see DINF-82)cmds.start(), which sometimes ends up printing the command output after the exit message instead of before.sort.Strings(want|have)that was there already fixes that.outputtest.Bufferbefore the command outputs get written to it.time.Sleep(300 * time.Milliseconds)mitigates/hides that problem.At least, this shouldn't blow up in CI and buys us time to fix the whole thing. We're tracking this in DINF-104. And out of 200 runs, I also stumbled once, on a race in
progress_tty, tracked in DINF-105 (that packages is originally meant to be used bysrc-cliand was re-used forsg3 years ago).I'm pretty unhappy about the solution, but a bandage is better than nothing. While ideally, we should really reconsider dropping
std.Outputentirely insgand use the good stuff from github.com/charmbracelet instead because we don't want to spend too much time on arcane terminal things ourselves, I'm much more about concerned the concurrency issues mentioned above. We'll circle back on this.Test plan
CI +
sg bazel test //dev/sg:sg_test --runs_per_test=100