Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(svelte): Add Cody chat sidebar#63638

Merged
fkling merged 5 commits into
mainfrom
fkling-srch-7-svelte-integrate-cody-web-into-file-view
Jul 4, 2024
Merged

feat(svelte): Add Cody chat sidebar#63638
fkling merged 5 commits into
mainfrom
fkling-srch-7-svelte-integrate-cody-web-into-file-view

Conversation

@fkling

@fkling fkling commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

This commit adds the React version of the cody chat sidebar to the Svelte web app. I used @vovakulikov's work in the React app as guidance.

I'm sure we'll have to do follow up work, but it's a start.

This PR also fixes sg start web-sveltekit-standalone (because I originally thought that running it from sourcegraph.test is necessary to make auth work).

Test plan

Manual testing.

sg-sk-cody.mp4

This commit adds the React version of the cody chat sidebar to the
Svelte web app.
@fkling fkling requested review from camdencheek and vovakulikov July 4, 2024 10:56
@fkling fkling self-assigned this Jul 4, 2024
@cla-bot cla-bot Bot added the cla-signed label Jul 4, 2024

function handleClick(): void {
$rightPanelOpen = true
// TELEMETRY_RECORDER.recordEvent('repo.goToCodeHost', 'click')

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to find the right event for this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up removing this because in the React app we seem to logging a "transcript id" which we don't have here.

@vovakulikov vovakulikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, one thing which isn't a blocker I guess, I'm not sure how it's supposed to work on dot com but Cody Ignore is something we also should support (there is a settings mechanism which disables Cody Web chat for some particular files and repositories, maybe on dot com it's always available for everything)

@fkling

fkling commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

I think I know what you mean. I saw for the inline cody widget there was a hook that checks whether cody is enabled for the current file. I guess that's handled somewhere else for the sidebar and is something we should port over.

@fkling fkling merged commit f0c9551 into main Jul 4, 2024
@fkling fkling deleted the fkling-srch-7-svelte-integrate-cody-web-into-file-view branch July 4, 2024 20:50
@taiyab

taiyab commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

Amazing PR Felix. Incredible work.

(Darn you, I thought there was a problem with my env not being able to run sg start web-sveltekit-standalone!) :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants