This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add GenericProviderConfig.ServiceName#63626
Merged
Merged
Conversation
emidoots
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to use the
types.ModelConfigurationdata to configure completion providers, it became clear I missed something.We expose the
types.GenericProviderConfigas a bare-bones way to express LLM provider configuration, and it does great. But just knowing the (endpoint, access token) isn't enough to actually serve requests.We need to know the shape of API requests. e.g. if we should pass that endpoint/access to an OpenAI-compatible, Fireworks-compatible, or Google-compatible API provider.
Test plan
Added new unit tests
Changelog
NA