This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Pick up CompletionsConfig.User for the AzureOpenAI API Provider#63621
Merged
Conversation
emidoots
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small oversight when we convert the site config's "completions" configuration data into the
modelconfig/types.SiteModelConfigobject.PR https://github.com/sourcegraph/sourcegraph/commit/8e37fcac2632692e430f6b53722a99528df6902a#diff-3c40fc45ac5714fdcbcfb874321044afe3ef449134adcf519d4fba5b966cf18fR71 added a new
Userfield to the site configuration, which is used by the Azure OpenAI API provider.So this piece of data needs to be put into the
internal/modelconfig/types.AzureOpenAIProviderConfigfield so it can available when we refactor theinternal/completions/client/azureopenaipackage.Since rather than pulling this information from the
internal/completions.CompletionRequestParameters::Userwe will instead pass theinternal/modelconfig/types.AzureOpenAIProviderConfigobject, which will have all the Azure OpenAI-specific server-side configuration.Test plan
NA
Changelog
NA