This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: add mutation observer to sizeToFit#63620
Merged
Merged
Conversation
fkling
approved these changes
Jul 3, 2024
| const resizeObserver = new ResizeObserver(resizeOnce) | ||
| resizeObserver.observe(target) | ||
| const mutationObserver = new MutationObserver(resizeOnce) | ||
| mutationObserver.observe(target, { attributes: true, childList: true, characterData: true, subtree: true }) |
Member
Author
There was a problem hiding this comment.
Attributes can change the size of the element, right?
Contributor
There was a problem hiding this comment.
Ah, I guess if style or class changes... yeah.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this only listened for resize events. However, shrink/grow might also be required if the contents of the element change. This adds a
MutationObservertosizeToFitto recalculate the sizing when the element (or its children) is mutated.Fixes SRCH-679
Test plan
https://share.cleanshot.com/Xdz6g16m