This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add SourcegraphModelConfig.AccessToken#63619
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small design oversight when creating the
SourcegraphModelConfig.The
SourcegraphModelConfigtype contains all the configuration knobs for a Sourcegraph admin to control how the "Sourcegraph-supplied LLM models" should be used. For example:null, then Sourcegraph will not provide any LLM models for the instance. And only the admin-supplied providers and models will be used.However, there's something that is lost in translation between "site admin configuring how LLM models get picked up" and "generating the
types.ModelConfigurationdata structure needed at runtime".In order to actually use Cody Gateway at runtime, the Completions Provider needs to know the URL endpoint and access token for Cody Gateway. This is made available via the
types.Provider.ServerSideConfig.SourcegraphProviderfield. (So when creating the "google" completions provider, that's how we know to send the request to Cody Gateway, etc.)But with the data type we have right now, this data is missing.
With the current way you can configure Cody Enterprise, the
accessTokenfield is optional. Because when we load the configuration, the Sourcegraph instance will automatically create a new access token based on the license key.But as we transition to the new-style configuration data, we will no longer be able to rely on
CompletionsConfig.AccessToken.So specifically:
types.SourcegraphModelConfigconfig data type, so that when we are building thetypes.ModelConfigurationwe know how to create the provider information to contact Cody Gateway as needed.types.SourcegraphModelConfigin their Site configuration data. (And continue to just generate a token based on the license key.)Test plan
NA
Changelog
NA