This repository was archived by the owner on Sep 30, 2024. It is now read-only.
refactor(github): Have a dedicated PublicRepository type#63607
Merged
Conversation
eseliger
approved these changes
Jul 3, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
I'm surprised no golden files needed to be updated here, but great change - thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repositories returned from GitHub's public repositories endpoint has a reduced set of fields and has led to bugs in the past.
This PR introduces a dedicated PublicRepository type that prevents us from relying on fields that don't exist.
Test plan
This is used only in 1 place so tests should still pass.
Changelog